Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LAION 2B only training #145

Closed
wants to merge 4 commits into from
Closed

add LAION 2B only training #145

wants to merge 4 commits into from

Conversation

Soonhwan-Kwon
Copy link

add LAION 2B only training related to the issue below
#137

@Soonhwan-Kwon
Copy link
Author

it is strange when I run psf/black on my machine, it outputs

python -m black open_flamingo/
reformatted /data4/open_flamingo/open_flamingo/train/train_utils.py

All done! ✨ 🍰 ✨
1 file reformatted, 19 files left unchanged.

@anas-awadalla
Copy link
Collaborator

Can you upgrade black? I remember I ran into this problem earlier and that was the fix. If not no worries! Thanks for putting this together. I will take a look and merge :)

@anas-awadalla anas-awadalla mentioned this pull request Apr 1, 2023
Closed
@anas-awadalla anas-awadalla self-requested a review April 1, 2023 20:08
anas-awadalla
anas-awadalla requested changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@anas-awadalla anas-awadalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I think we should first clean up the duplicate code in train_utils.py before merging.

open_flamingo/train/train_utils.py Outdated Show resolved Hide resolved
open_flamingo/train/train_utils.py Show resolved Hide resolved
@Soonhwan-Kwon
Copy link
Author

I committed updates last week, and I tested run for laion dataset. Please let me know if there are more feedbacks.

@anas-awadalla
Copy link
Collaborator

Thanks @Soonhwan-Kwon! We will merge this but may take a few days for me to do so.

@i-gao i-gao mentioned this pull request Jul 6, 2023
Open
@anas-awadalla anas-awadalla mentioned this pull request Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anas-awadalla anas-awadalla anas-awadalla requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soonhwan-Kwon @anas-awadalla